Migrate Substack Articles to blog/
#107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging payjoin#104 revealed a build failure due to broken links in the markdown on two articles. Docusaurus automatically fails the build as a favor to us, we could bypass this but I consider this advanced linting that helps us out. These links are broken in the current payjoindevkit.org articles because Vuepress doesn't check them. I fixed these links and the build now passes locally. There were also several warnings in the output suggesting improvements: - [x] Deprecation of `onBrokenMarkdownLinks` being in the parent config when it should live as a subattribute of the `markdown` property. - [x] Addition of an [`authors.yml`](https://docusaurus.io/docs/blog#global-authors) file under `blog/` which has global metadata about blog authors. That way, each blog need only specify the author(s) and nice metadata will display. Take a look and ensure that the metadata I added (really, just Github profile information and names where given in Githubs) and make sure it is acceptable/complete enough for now. - [x] `<!-- truncate -->` comment which serves as a divider for what to display in the blog summary, a feature payjoindevkit.org doesn't currently have. - [x] A warning indicating Docusaurus can be updated, which I did and which updated `yarn.lock`
DanGould
reviewed
Nov 5, 2025
Contributor
DanGould
left a comment
DanGould
left a comment
There was a problem hiding this comment.
The only iframe I see is the wallet table one, and it's kind of jank still, doesn't let you copy text. Could we just pull an image instead?
| src="https://substack-post-media.s3.amazonaws.com/public/images/8f86ee7e-a0f6-45a4-b2f5-d76c6fde10fb_1193x1239.png" | ||
| title="The table of payjoin adoption status from the wiki" | ||
| class="sizing-normal" | ||
| data-attrs="{"src":"https://substack-post-media.s3.amazonaws.com/public/images/8f86ee7e-a0f6-45a4-b2f5-d76c6fde10fb_1193x1239.png","srcNoWatermark":null,"fullscreen":null,"imageSize":null,"height":1239,"width":1193,"resizeWidth":null,"bytes":350794,"alt":"The table of payjoin adoption status from the wiki","title":null,"type":"image/png","href":null,"belowTheFold":false,"topImage":true,"internalRedirect":null,"isProcessing":false,"align":null,"offset":false}" |
Contributor
There was a problem hiding this comment.
we definitely want to pull any substack images into this repo, though it can be a follow up commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: please review #105 first.
Migrates all published articles from payjoin.substack.com to the blog section with added frontmatter and tweaks where necessary to get iframes working.
Converted from html to markdown files via
pandocwith edits to not break Docusaurus' markdown linter.