Conversation
Pull Request Test Coverage Report for Build 21574637307Details
💛 - Coveralls |
DanGould
left a comment
There was a problem hiding this comment.
Whoa, massive PR! Thanks for your contribution.
I am curious about the history first. Having a bit of trouble understanding how this came together piece by piece because as far as I can tell each commit does not build on the previous one (in that I can run some code at each stage and see it evolve from a simple MVP to a full blown precompilation software tooling suite). Can you help me understand what each piece does?
One example of something I'm confused about is the dart CLI to build. What does that do that benefits from dart tooling vs some universal tooling that could work across projects (if that's even possible, I really don't know).
This is going to be really hard to review as 6k lines. Is there any intermediate step that or guidance you could give me to make this easier to review?
CI failure is OK for a start but we'll have to address that to merge, too.
| !example.config.toml | ||
| *.sqlite | ||
| Cargo.lock | ||
|
|
| dependencies: | ||
| payjoin: | ||
| path: ../rust-payjoin/payjoin-ffi/dart | ||
| ``` |
There was a problem hiding this comment.
Shouldn't the SOP be to get this from pub.dev? Why mention path?
| dart test | ||
| ``` | ||
|
|
||
| Maintainers: see `docs/precompiled_binaries.md` for CI details, manual release steps, and configuration. |
There was a problem hiding this comment.
I don't think this file exists as of commit 1e57740 where this is introduced
There was a problem hiding this comment.
Oops, yes, adding it now.
There was a problem hiding this comment.
May you explain the purpose of this file? I'm new to precompiled binaries and it's not readily apparent what this is for. If the rationale was left in a the commit log it'd be super helpful for review.
Details
Precompiled Binaries Feature
Resolves #1308
This PR introduces a comprehensive precompiled binaries system that significantly improves the developer experience by reducing build times and providing secure, signed artifacts.
Key Features
Secure Distribution
Performance Improvements
auto,always, orneverDeveloper Experience
Configuration
Users can configure precompiled binaries in their
pubspec.yaml:Defaulting to auto which most users would want.
Done the old fashioned way without AI
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.