Draft
Conversation
Enable advisory (non-blocking) AI review on PRs touching Rust source in payjoin/ and payjoin-cli/. Uses the "chill" profile with noisy features disabled. Path instructions focus on C-CALLER-CONTROL violations (pub fn taking &T but internally cloning) and broader Rust API guidelines from the checklist at rust-lang.github.io/api-guidelines. Closes payjoin#1374
Enable auto_review.drafts so CodeRabbit reviews draft PRs instead of skipping them. Disable review_status since CodeRabbit already reports via commit status checks (pending/success), making the walkthrough status messages redundant.
Enable CodeRabbit reviews on draft PRs
Disable all CodeRabbit noise, keep only path reviews
Replace the two-step Issue→Discussion standup flow with a single Discussion-based system that auto-gathers each contributor's weekly activity (merged PRs, reviews, issues) and creates pre-populated threaded replies. Changes: - Add create_standup_discussion.py with GitHub API activity gathering and GraphQL Discussion/comment creation - Update standup-prompt.yml to call new script and pass DISCUSSION_CATEGORY_NODE_ID - Remove compile_standup.py and standup-compile.yml since the Discussion IS the standup (no compile step needed) - Remove create_standup_issue.py (superseded)
When DRY_RUN is set, gather activity and print what would be posted without creating a Discussion or sending notifications.
Runs Tuesday 06:00 UTC before the standup meeting. Edits the Discussion body to show which contributors replied to their thread. Uses an HTML comment marker so re-runs update in place rather than appending.
Collaborator
Pull Request Test Coverage Report for Build 22753536316Details
💛 - Coveralls |
DanGould
force-pushed
the
async-standup-v2
branch
from
096b87c to
2f82c56
Compare
Async standup v2
The bot token is an org member, so org:payjoin searches return results from private repos. Those titles and URLs would be published into the public Discussion, leaking private work. Replace the org: search qualifier with explicit repo: qualifiers for each public repo to ensure only public activity is surfaced.
Search explicit public repos instead of org
The bot token is an org member, so org:payjoin searches return results from private repos. Those titles and URLs would be published into the public Discussion, leaking private work. Replace the org: search qualifier with explicit repo: qualifiers for each public repo to ensure only public activity is surfaced.
DanGould
force-pushed
the
async-standup-v2
branch
from
b342adc to
fab2bfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standup v2: Async Check-in Switchover
Starting Monday Mar 9, we're replacing async Issue standups with a weekly async Discussion thread based on feedback from early attempts. Here's what's changing:
Format: Each Monday a Discussion is posted with a per-person thread. Your thread is pre-filled with an auto-SHIPPED section gathered Discussion-first (not Issue) — searchable, threaded, persistent, no deleted issue
This is a 4-week experiment. Week 5 (Apr 6) we run a retro. If the format isn't working, we revert.
co-authored by Claude
@arminsabouri is tracking participation and bottleneck-resolution weekly. Questions or concerns reply here.
I still need to run a DRY_RUN=1 action here supported by the new script (Just set the envvar and look at the output in actions console. If I'm asleep when this merges and you do it instead, dear reviewer)
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.