Remove sequence param from InputPair constructors#1405
Merged
arminsabouri merged 1 commit intopayjoin:masterfrom Mar 11, 2026
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 22933330218Details
💛 - Coveralls |
The sequence parameter in InputPair::new_*() constructors was never used because contribute_inputs() always overrides the sequence to match the sender's first input, to prevent mixed sequence numbers in the payjoin proposal.
spacebear21
force-pushed
the
remove-sequence-inputpair-constructors
branch
from
4a39fb0 to
646b048
Compare
Mshehu5
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1404
The sequence parameter in InputPair::new_*() constructors was never used because contribute_inputs() always overrides the sequence to match the sender's first input, to prevent mixed sequence numbers in the payjoin proposal.
Authored by Claude
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.