Async callback wrappers in FFI#1425
Closed
spacebear21 wants to merge 2 commits intopayjoin:masterfrom
Closed
Conversation
Gate tokio behind a new `async_callbacks` feature so downstream languages (e.g. Dart) can opt-in to async callback bridging without pulling tokio into default builds.
Introduce async alternatives for the five receiver validation callbacks (CanBroadcast, IsScriptOwned, IsOutputKnown, ProcessPsbt, TransactionExists) behind the `async_callbacks` feature flag. Languages like Dart are inherently async and cannot block inside a sync callback. The bridge methods accept async callback traits and use `tokio::task::block_in_place` + `Handle::current().block_on()` to call them from within the core library's sync closure API, avoiding breaking changes to the core.
Collaborator
Pull Request Test Coverage Report for Build 23310324081Details
💛 - Coveralls |
Collaborator
Author
|
Closing this approach as it doesn't work with wasm targets i.e. doesn't solve the issue for JS bindings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm exploring this approach as a workaround for FFI downstream languages, without needing to modify the core rust API. Code by ClaudeTM
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.