Async client bitcoind network parsing#1426
Open
benalleng wants to merge 2 commits intopayjoin:masterfrom
Open
Conversation
benalleng
changed the title
benalleng
force-pushed
the
async-client-bitcoind-parsing
branch
from
bc6d10a to
3e3e489
Compare
Because rust-bitcoin and bitcoind have different naming schemes for the network chains we cannot use a simple FromStr impl to parse them and should instead use the built-in from_core_args method when referencing bitcoind directly.
benalleng
force-pushed
the
async-client-bitcoind-parsing
branch
from
3e3e489 to
e169739
Compare
Collaborator
Pull Request Test Coverage Report for Build 23340659336Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because rust-bitcoin and bitcoind have different naming schemes for the
network chains we cannot use a simple FromStr impl to parse them and
should instead use the built-in from_core_args method when referencing
bitcoind directly.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.