Sanitize shortid when storing metrics#1434
Open
zealsham wants to merge 1 commit intopayjoin:masterfrom
Open
Conversation
This pr addresses part of payjoin#1421. It replaces the actual unique mailbox identifier with "{short_id} when storing http metrics. Exposing the unique identifiers in metrics is a privacy/security risk
Collaborator
Pull Request Test Coverage Report for Build 23390790251Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr addresses part of #1421. It replaces the actual unique mailbox identifier with "{short_id} when storing http metrics. Exposing the unique identifiers in metrics is a privacy/security risk.
chatgpt helped me extract the exact metric from the inmemory opentelemetry exporter
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.