Disable reqwest dep when _manual-tls is enabled in the payjoin crate#1484
Merged
spacebear21 merged 1 commit intopayjoin:masterfrom Apr 15, 2026
Merged
Conversation
The reqwest dep is enabled in the _manual-tls feature pulling in url as a sub dependency but this is only used in conjunction with the io feature which already has reqwest as a dep.
benalleng
force-pushed
the
manual-tls-disable-reqwest
branch
from
3f31c18 to
90dabd6
Compare
Collaborator
Coverage Report for CI Build 24464733809Coverage remained the same at 84.34%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reqwest dep is enabled in the _manual-tls feature pulling in url as a sub dependency but this is only used in conjunction with the io feature which already has reqwest as a dep.
Closes #1483
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.