docs: clarify bech32 uppercase assertion TODO#1488
Closed
codaMW wants to merge 1 commit into
Closed
Conversation
The existing TODO comment was ambiguous. This adds context by referencing BIP 173, clarifying that an actual assertion should be added in the future. This is a documentation-only change.
benalleng
reviewed
Apr 16, 2026
Collaborator
benalleng
left a comment
benalleng
left a comment
There was a problem hiding this comment.
This is a bit of a nothing PR, I woul rather you take on the change for the actual assert implementation.
Take a look at some other now-closed bech32 PRs relating to this like #1100 to make sure you get the assert content correct
Contributor
Author
|
@benalleng Thanks for the honest feedback and the pointer to #1100. After reviewing it, I understand why that approach didn't land, the character set check in the test was incorrect, and the maintainers ultimately decided against the change. Given the history, I think it's best to close this PR and focus on more impactful contributions. I'll look for issues with active maintainer interest instead. Appreciate the guidance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies the intent of an existing TODO comment per BIP 173, clarifying that an actual assertion should be added in the future.
This is a documentation-only change.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.