fix(test): remove payjoin-ffi from root CRATES and update ffi test script#1492
Open
caarloshenriq wants to merge 1 commit intopayjoin:masterfrom
Open
fix(test): remove payjoin-ffi from root CRATES and update ffi test script#1492caarloshenriq wants to merge 1 commit intopayjoin:masterfrom
caarloshenriq wants to merge 1 commit intopayjoin:masterfrom
Conversation
Collaborator
Coverage Report for CI Build 24753654691Coverage remained the same at 84.92%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
caarloshenriq
force-pushed
the
fix/payjoin-ffi-test-infra
branch
from
989762f to
c88e353
Compare
spacebear21
reviewed
Apr 20, 2026
Collaborator
|
I think that the |
…ript payjoin-ffi tests were either being skipped due to an unnecessary MSRV version check or entangling language binding tests with core rust CI. - Remove payjoin-ffi from CRATES in root contrib/test.sh and contrib/test_local.sh - Remove MSRV version check from payjoin-ffi/contrib/test.sh - Add cargo test for payjoin-ffi rust code - Loop over language bindings (dart, javascript, python) and run their contrib/test.sh
caarloshenriq
force-pushed
the
fix/payjoin-ffi-test-infra
branch
from
c88e353 to
da1eaca
Compare
Contributor
Author
Fixed, added execution permissions to dart script via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1454
payjoin-ffi tests were either being skipped due to an unnecessary MSRV version check or entangling language binding tests with core rust CI.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.