Fix HTTP error handling in payjoin-cli#1499
Merged
spacebear21 merged 1 commit intopayjoin:masterfrom Apr 22, 2026
Merged
Conversation
It was not handling HTTP error status codes correctly since any response is considered successful by reqwest without `error_for_status()`.
Collaborator
Coverage Report for CI Build 24789507463Coverage increased (+0.03%) to 84.953%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing @Arowolokehinde 's PR #1498 I noticed that cli was attempting to process the OHTTP response even though it was returning a 403. This fix ensures we actually bubble up HTTP error responses from the ohttp relay:
Before:
After:
Closes #1394
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.