Update use of deprecated from_sat_per_vb_unchecked#1502
Merged
spacebear21 merged 2 commits intopayjoin:masterfrom Apr 23, 2026
Merged
Update use of deprecated from_sat_per_vb_unchecked#1502spacebear21 merged 2 commits intopayjoin:masterfrom
spacebear21 merged 2 commits intopayjoin:masterfrom
Conversation
This commit replaces from_sat_per_vb_unchecked with from_sat_per_vb_u32 as the previous method is now deprecated. Curious though is that it says it has been deprecated since 0.32.7 but we have been on 0.32.8 for quite some time with no issues..?
Collaborator
Coverage Report for CI Build 24856548316Coverage remained the same at 84.953%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
benalleng
force-pushed
the
update-bitcoin-units
branch
from
6663db6 to
ea72272
Compare
benalleng
force-pushed
the
update-bitcoin-units
branch
from
ea72272 to
f717818
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit replaces from_sat_per_vb_unchecked with from_sat_per_vb_u32 as the previous method is now deprecated. Curious though is that it says it has been deprecated since 0.32.7 but we have been on 0.32.8 for quite some time with no issues..?
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.