Nixify Javascript FFi tests#1572
Merged
Merged
Conversation
Collaborator
Coverage Report for CI Build 26251069322Coverage remained the same at 85.14%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Collaborator
|
sidenote: i think we should evaluate moving off of MSRV for payjoin-ffi to avoid constant dependency headaches with uniffi-rs and third party generator libraries. payjoin-ffi is just generator code, so MSRV compatibility is mostly irrelevant for downstream language consumers. We'll still want to pin to a specific rust version instead of just "stable" to ensure reproducible builds, but it doesn't need to be as low as 1.85. |
Collaborator
Author
|
Ok! I was going to ask about this but stuck with msrv for now, going to validate first that we can limit this down to only needing the nix step similar to #1536 |
This commit adds wasm32-unknown-unknown to fix a bug where rustup target add was ignored by generate_bindings.sh As well adds env configuration to fix a bug where cc-rs is invoked in the new target. Add bindgen-cli pin in nix
Remove msrv rust toolchain env
spacebear21
approved these changes
May 21, 2026
Collaborator
spacebear21
left a comment
spacebear21
left a comment
There was a problem hiding this comment.
utACK, CI looks good and takes about as long as before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./payjoin-ffi/javascript/contrib/test.shwas failing within thenix develop .#msrvdev shell.The first commit fixes the failure itself and the second commit is a way for the workflow to ensure that it always runs and a step further in nixifying the CI. Currently this still selects our current msrv to be locked at 1.85.0 but perhaps this is too strict and not really necessary for the users of the ffi bindings and maybe we should choose a higher fixed stable "ssrv"
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.