Look up RK instead of looping#1706
Merged
Merged
Conversation
Collaborator
Coverage Report for CI Build 28665120300Coverage decreased (-0.04%) to 85.899%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions7 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
Collaborator
Author
|
@DanGould I think this PR still has utility even after our upgrade to uuid v7 simply for the sake of code simplification on the sender side. |
DanGould
previously approved these changes
Jul 3, 2026
Follow up from payjoin#995. We can replace a loop over all active session ids with a WHERE clause.
xstoicunicornx
approved these changes
Jul 5, 2026
xstoicunicornx
left a comment
Collaborator
There was a problem hiding this comment.
utACK 2490ef2
Reviewed changes and tested locally. This is a much more straightforward implementation that avoids unnecessary db calls made by the now unneeded loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #995. We can replace a loop over all active session ids with a WHERE clause.
Supersedes #1013
since this helper function returns a
Result<Option<SessionId>>I opted to move some match error handing within the function itself instead of matching at thesend_payjoinlevelAdditionally adds some enhacements suggested from the original PR like adding
"completed_at IS NULL"Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.