Expose Block Height to TxHandle#34
Merged
arminsabouri merged 1 commit intopayjoin:masterfrom Apr 3, 2026
Merged
Conversation
Contributor
Author
|
part of #26 |
Contributor
Author
|
initially I exposed |
arminsabouri
requested changes
Mar 31, 2026
| tx.input[vin].script_sig.to_bytes() | ||
| } | ||
|
|
||
| fn block_height(&self, txid: &AnyTxId) -> Option<u64> { |
Collaborator
There was a problem hiding this comment.
Should this not return None if id type is loose? This question related to #35 . There are way too many foot guns with the way unified storage is written today
Contributor
Author
There was a problem hiding this comment.
yes, that's the idea, but this is changing with #38 to be more explicit, so I'll leave this PR as a draft until we merge
| )?; | ||
| let storage = DenseStorage { | ||
| blocks_dir: parser.blocks_dir().to_path_buf(), | ||
| block_height_offset: height_offset, |
Collaborator
There was a problem hiding this comment.
Avoid assignment
Suggested change
| block_height_offset: height_offset, | |
| block_height_offset: range.start |
arminsabouri
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds
block_heighttoTxHandleviaTxIoIndex, allowing heuristics to query the confirmed block height of a transaction.block_of_txnow returns the absolute chain height instead of a range-relative index, by storingrange.startas an offset inDenseStorageat index timepart of #5