Skip to content

feat: add token tds_finish.#44

Merged
nonz250 merged 3 commits intomasterfrom
nonz250/feat-token-tds-finish
Nov 15, 2024
Merged

feat: add token tds_finish.#44
nonz250 merged 3 commits intomasterfrom
nonz250/feat-token-tds-finish

Conversation

@nonz250
Copy link
Copy Markdown
Member

@nonz250 nonz250 commented Nov 14, 2024

Overview

add token tds_finish.

Changes

  • add token tds_finish.
  • add card three_d_secure_status param.

@nonz250 nonz250 self-assigned this Nov 14, 2024
@nonz250 nonz250 requested review from feiz and natsuki-yamanaka and removed request for feiz November 14, 2024 09:18
@nonz250 nonz250 marked this pull request as ready for review November 15, 2024 01:28
Copy link
Copy Markdown
Contributor

@natsuki-yamanaka natsuki-yamanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一個だけ

public void testTokenTdsFinish() throws PayjpException {
stubNetwork(Token.class, "{\"id\":\"tok_xxxxxxxxxxxxxxxxxxxxxxxx\"}");
Token token = Token.tdsFinish("tok_xxxxxxxxxxxxxxxxxxxxxxxx", null, null);
assertEquals("tok_xxxxxxxxxxxxxxxxxxxxxxxx", token.getId());
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こんなの足したいですね

verifyPost(Token.class, "https://api.pay.jp/v1/tokens/tok_xxxxxxxxxxxxxxxxxxxxxxxx/tds_finish", null);

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正しました✍
イメージあってますかね?
036c147

@nonz250 nonz250 merged commit 740bf10 into master Nov 15, 2024
@nonz250 nonz250 deleted the nonz250/feat-token-tds-finish branch November 15, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants