-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix(next): cannot override tab of default views #11789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(next): cannot override tab of default views #11789
Conversation
|
Hi @jacobsfletch, what is the status of my PR? It's a blocker for my task. |
|
@chmielulu this looks good! One last thing to do here is to add a test. This can be done in admin test suite. You can see how we do this for other tab-related features here:
|
7db122d to
5c38773
Compare
5c38773 to
fac4d90
Compare
|
@jacobsfletch I've added tests :) |
|
@jacobsfletch Just a friendly reminder, thanks in advance! 😃 |
|
Bump. @jacobsfletch what is the status of my PR? |
jacobsfletch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
🚀 This is included in version v3.41.0 |
What?
TypeScript says that it is possible to modify the tab of the default view however, when you specify the path to the custom component, nothing happens. I fixed it.
How?
If a Component for the tab of the default view is defined in the config, I return that Component instead of DocumentTab
Example Configuration
config.ts
./TestComponent.tsx
Before
After