feat: adds new canSetHeaders prop to auth strategies #12591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikrut
changed the title
AlessioGr
approved these changes
May 28, 2025
AlessioGr
requested changes
May 28, 2025
Member
AlessioGr
left a comment
AlessioGr
left a comment
There was a problem hiding this comment.
Actually found one more thing - can we default canSetHeaders to true? Or alternatively invert it (cannotSetHeaders).
I think now, a normal fetch request would incorrectly have canSetHeaders: false
AlessioGr
approved these changes
May 28, 2025
Member
AlessioGr
left a comment
AlessioGr
left a comment
There was a problem hiding this comment.
Nevermind! Just saw you added canSetHeaders: true in utilities/handleEndpoints.ts
Contributor
|
🚀 This is included in version v3.40.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes a new argument to authentication strategies which allows the author to determine if this auth strategy has the capability of setting response headers or not.
This is useful because some auth strategies may want to set headers, but in Next.js server components (AKA the admin panel), it's not possible to set headers. It is, however, possible to set headers within API responses and similar contexts.
So, an author might decide to only run operations that require setting headers (i.e. refreshing an access token) if the auth strategy is being executed in contexts where setting headers is possible.