fix: disable alphabetical sorting of relationship field search results if already sorted on backend #13677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ationship field if a non ID field is used for sorting
jefvel
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
|
Waiting for this! 🙋♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The relationship field options uses the collection's
defaultSortorsortOptionsprops to sort search results in the back end. Currently it will also always alphabetically sort the options on the front end. This PR conditionally disables that alphabetical sorting.Why?
The alphabetical sort can make the options list jump around when searching, and overrides the preferred sorting of search results.
How?
Checks if the
sortparam is not set to defaultid, and determines whether or not to sort on the front end.Before:
clientside-sorted.mp4
After:
Kapture.2025-09-03.at.15.38.26.mp4
Hope this is an acceptable solution, feedback is welcome in case there's a better way :)
Thanks!