fix(plugin-import-export): incorrect user type in Export causing runtime type mismatch #14790
+29
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Separated user serialization concerns from runtime user handling in the export plugin by moving
useranduserCollectionfields out of the baseExporttype into a newExportJobInputtype, and using a separateuserparameter inCreateExportArgs.Why?
The
Exporttype haduser: stringwhich was meant for job queue serialization, but when exports ran directly (without job queue), the full user object was being passed where a string was expected. This created a type mismatch that only worked by accident at runtime.How?
useranduserCollectionfrom baseExporttypeExportJobInputtype that extendsExportwith serialization fieldsCreateExportArgsto acceptuser?: TypedUser | nullas separate parametercreateExport