fix(richtext-lexical,ui): make uploadNode default to alt user-defined values.#15097
Merged
GermanJablo merged 1 commit intomainfrom Jan 6, 2026
Merged
fix(richtext-lexical,ui): make uploadNode default to alt user-defined values.#15097GermanJablo merged 1 commit intomainfrom
alt user-defined values.#15097GermanJablo merged 1 commit intomainfrom
Conversation
alt user-defined values.alt user-defined values.
alt user-defined values.alt user-defined values.
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
paulpopus
approved these changes
Jan 6, 2026
teastudiopl
pushed a commit
to teastudiopl/payload
that referenced
this pull request
Jan 8, 2026
…ed values. (payloadcms#15097) Fix payloadcms#14780 There are 2 ways a user can add fields to UploadNode within richtext: ```ts // 1. Media Collection export const Media: CollectionConfig = { slug: 'media', fields: [ { name: 'alt', type: 'text' } // ← Default alt for the image ], upload: true, } // 2. UploadFeature in Lexical (Per-instance override) UploadFeature({ collections: { media: { fields: [ { name: 'alt', type: 'text' } // ← Context-specific alt per usage ] } } }) ``` This PR updates all upload converters (JSX, HTML async/sync, Slate, and UI components) to intelligently resolve the `alt` attribute with the following priority: 1. **UploadFeature `fields.alt`** - Context-specific override 2. **Media collection `alt`** - Default from document 3. **Empty string** - Accessibility fallback (instead of using filename) This prevents users from having to manually override converters to achieve proper alt text handling. **Implementation note:** Type assertions are required since both `alt` fields are user-defined and don't exist in the core types at compile time.
Contributor
|
🚀 This is included in version v3.71.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #14780
There are 2 ways a user can add fields to UploadNode within richtext:
This PR updates all upload converters (JSX, HTML async/sync, Slate, and UI components) to intelligently resolve the
altattribute with the following priority:fields.alt- Context-specific overridealt- Default from documentThis prevents users from having to manually override converters to achieve proper alt text handling.
Implementation note: Type assertions are required since both
altfields are user-defined and don't exist in the core types at compile time.