fix(ui): use the formatAdminUrl function to generate unpublish url #15375
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Muhammad-Hassaan-Farooq
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
Muhammad-Hassaan-Farooq
changed the title
JarrodMFlesch
requested changes
Jan 27, 2026
| url = `${serverURL}${api}/${collectionSlug}/${id}${queryString}` | ||
| url = formatAdminURL({ | ||
| apiRoute: api, | ||
| path: `/${collectionSlug}${id ? `/${id}` : ''}${queryString}`, |
Contributor
There was a problem hiding this comment.
do we need to check for id? unpublish would mean you have a doc already, yeah?
There was a problem hiding this comment.
Yeah true. Let me remove the check
JarrodMFlesch
approved these changes
Jan 27, 2026
Contributor
|
🚀 This is included in version v3.74.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The unpublish button on the admin panel sends a request to the wrong url if the application has a base path configured in the next config. This PR uses the formatAdminURL function to conditionally add the base path if needed.
Why?
Unpublish button does not work if base path is set.
How?
Using the formatAdminURL correctly includes the basePath in the url
Fixes #15369