-
Notifications
You must be signed in to change notification settings - Fork 3.3k
test: make integration tests for the fields and select suites faster
#15434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
| locale: 'es', | ||
| collection: 'indexed-fields', | ||
| data: { localizedUniqueRequiredText: '40' }, | ||
| data: { localizedUniqueRequiredText: 'unique-hasMany40-' + Date.now() }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion: in vitest, you can get the current test name via task.name. If you hash that, you can get a per-test unique string and never have to worry about unique-hasMany(n) colliding with another string in another test.
|
🚀 This is included in version v3.74.0 |
We were restarting and seeding the database in each test. By removing the
beforeEachstatement, a handful of tests required refactoring to avoid conflicts with others.beforeEachseed →beforeAllseedbeforeEachcreate →beforeAllcreateTime Saved Per Test Run