fix: in slugField let position: undefined correctly reset admin.position#15725
Open
zampage wants to merge 1 commit intopayloadcms:mainfrom
Open
fix: in slugField let position: undefined correctly reset admin.position#15725zampage wants to merge 1 commit intopayloadcms:mainfrom
zampage wants to merge 1 commit intopayloadcms:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
slugFieldprovides the optionpositionwhich accepts'sidebar' | undefined.This option is used to populate
admin.position.Per default the
slugFieldaddssidebarwhen destructuring, making it render in the sidebar.However providing
undefined, with the intent to not render it in the sidebar, does not change this behavior.The default assignment of
position = 'sidebar'while destructuring takes precedence over a providedundefined.Since the
positionoption exists, it should work with both valid values'sidebar'andundefined, which currently it does not.Workaround
A possible workaround before this fix was to use the
overridesoption ofslugFieldlike this:Fix
My fix checks the provided options for
'position' in options. Therefore allowingundefinedto be passed successfully and not be overriden withsidebar.This allows
undefinedto be passed toadmin.positionand therefore render the slugfield correctly.Discord community help source
https://discord.com/channels/967097582721572934/1475457110119546942