fix(db-postgres): stabilize read replicas support#16083
Merged
Conversation
Closed
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖 |
JarrodMFlesch
approved these changes
Mar 30, 2026
Contributor
JarrodMFlesch
left a comment
There was a problem hiding this comment.
Sasha and I chatted about the confusing db variables being created and Sasha landed on passing the result of getTransaction directly into getPrimaryDB. This change made it easier to read and I think less error prone going forward. Now there is only 1 db var in each file.
Contributor
|
🚀 This is included in version v3.81.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
postgres-replicasconfiguration to ourdocker-compose.yml.postgres-read-replicasdatabase adapter option.test/database/pg-replica/int.spec.tsfor thereadReplicaspropertyProblem
When readReplicas is configured, reads that happen as part of writes (e.g. reading back the row after an INSERT) were incorrectly routed to the replica instead of the primary, causing NotFound errors due to replication lag.
Solution
getPrimaryDb- used inupsertRow, updateOne,updateManyto always use the primary DB for internal reads in write operations.readReplicasAfterWriteInterval- time-based read-after-write consistency. Before, if you did for examplepayload.createand immediatelypayload.findafter - the new document would not show due to replication lag. Defaults to2000(ms) but can be configured.