perf: optimize setupOrderable by tracking during field sanitization#16134
Merged
JarrodMFlesch merged 1 commit intorefactor/sanitize-fieldfrom Apr 2, 2026
Merged
perf: optimize setupOrderable by tracking during field sanitization#16134JarrodMFlesch merged 1 commit intorefactor/sanitize-fieldfrom
JarrodMFlesch merged 1 commit intorefactor/sanitize-fieldfrom
Conversation
43edcd3 to
72890c1
Compare
2594496 to
5f69ae0
Compare
6e0177c to
0f69f04
Compare
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
5f69ae0 to
153faa1
Compare
…ization Instead of traversing all fields after sanitization to find orderable joins, track them during the existing sanitizeFields traversal. This eliminates the expensive traverseFields call in setupOrderable. Changes: - Add OrderableJoinInfo type to track orderable join fields - Pass orderableJoins tracker through field sanitization - Track orderable joins in sanitizeJoinField during sanitization - Inline setupOrderable logic into sanitizeConfig using tracked data - Use sanitizeField to properly sanitize orderable fields - Remove old setupOrderable function with its traverseFields call Performance: setupOrderable ~7ms → 0.06ms (~99% improvement)
0f69f04 to
1d1cf1c
Compare
JarrodMFlesch
added a commit
that referenced
this pull request
Apr 13, 2026
## Summary Adds lightweight profiling utilities for measuring execution time of sync and async functions. This is a developer tool for debugging performance issues during development — wrap any function with `timeSync` or `timeAsync` to measure its duration, then call `printProfileResults` to see a formatted table of timings. Not intended for production use or to be imported by default, just available when needed for performance investigations. These utilities were used to generate results for: - #16134 - #16129
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setupOrderablegoes from ~7ms to 0.06ms (~99% improvement)Instead of traversing all fields after sanitization to find orderable joins, this tracks them during the existing
sanitizeFieldstraversal. The expensivetraverseFieldscall insetupOrderableis eliminated.Adds
OrderableJoinInfotype to track orderable join fields during sanitization. The tracked data is then used to add orderable fields to target collections, using the newsanitizeFieldfunction from the base PR to properly sanitize them.