fix: pass data to update access in bulk update operation#16241
Open
fkkehlet wants to merge 1 commit intopayloadcms:mainfrom
Open
fix: pass data to update access in bulk update operation#16241fkkehlet wants to merge 1 commit intopayloadcms:mainfrom
fkkehlet wants to merge 1 commit intopayloadcms:mainfrom
Conversation
The bulk `updateOperation` does not pass `data` to `executeAccess` for the update access check, unlike `updateByIDOperation` which does. This makes it impossible for update access functions to inspect the incoming data — for example, to detect a trash (soft-delete) attempt by checking `data.deletedAt`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Pass
bulkUpdateDatatoexecuteAccessfor the update access check in the bulkupdateOperation, matching the existing behavior ofupdateByIDOperation.Why?
The bulk
updateOperationdoes not passdatato the update access function, whileupdateByIDOperationdoes. This means access functions cannot inspect the incoming update payload during bulk operations, for example, to detect a trash (soft-delete) attempt by checkingdata.deletedAt.This is inconsistent: the delete access check in the same function already passes
data: bulkUpdateData(line 160), but the update access check (line 133) omits it.In practice, this breaks collections that set
updateaccess based ondata— e.g., a form submissions collection that blocks regular edits (update: () => falsevia plugin defaults) but needs to allow trash operations by checkingdata.deletedAt.How?
One-line change in
packages/payload/src/collections/operations/update.ts:This matches updateByIDOperation (line 120 in
updateByID.ts):