fix(ui): properly translate folder view labels and buttons#16282
Open
jhb-dev wants to merge 1 commit intopayloadcms:mainfrom
Open
fix(ui): properly translate folder view labels and buttons#16282jhb-dev wants to merge 1 commit intopayloadcms:mainfrom
jhb-dev wants to merge 1 commit intopayloadcms:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes several broken translations in the folder view UI:
Why?
The folder collection config used hardcoded English labels (
{ plural: 'Folders', singular: 'Folder' }) that flowed into several UI labels viagetTranslation(), which returns the string as-is for non-translatable values.Multiple call sites also built button labels via string concatenation (
\${t('general:create')} \${label.toLowerCase()}), which produces incorrect output in non-English locales where:Finally,
general:clearAllwas only used as a "deselect all" button and was literally translated as "Clear all" / "Alles leeren" in most locales, which is misleading.How?
createFolderCollection.ts,buildFolderField.ts): switch labels to translation functions (({ t }) => t('folder:folder')/t('folder:folders')).SortByPill: uset('general:sortBy')/t('general:order').ItemCardGridcall sites inBrowseByFolderandgetFolderResultsComponentAndData: pass translated titles using existingfolder:folders/general:documentskeys.\${create} \${label.toLowerCase()}patterns witht('general:createNewLabel', { label })so word order and casing are decided by each locale's translation string.folder:folderandgeneral:sortBytranslation keys. Regenerate for all 43 non-English locales.general:clearAll→general:deselectAll(semantically correct, not used anywhere else). Regenerate translations.