fix(drizzle, db-mongodb): handle ['null'] array when filtering hasMany relationship field by None#16293
Open
lcnogueira wants to merge 5 commits intopayloadcms:mainfrom
Open
Conversation
…elationship by None
…lationship by None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
When filtering a
hasManyrelationship field by None in the Payload admin panel list view, no results are returned — even when documents with no related entries exist.Why?
The issue exists in both
packages/drizzle/src/queries/sanitizeQueryValue.tsandpackages/db-mongodb/src/queries/sanitizeQueryValue.ts, inside therelationship/uploadtype block.When the admin UI sends a "None" filter for a
hasManyrelationship field, the value arrives as['null']— an array containing the string'null'. The current null check in both adapters only handles the plain string form:Since
['null'] !== 'null', the check is bypassed. In the drizzle adapter, the['null']value then reaches the array-handling branch which convertsoperator: 'equals'tooperator: 'in'withvalue: ['null'], generating:In the MongoDB adapter, the unconverted
['null']value causes a query error, returning{ errors: [...] }instead of results.Both cases result in the filter producing no valid output.
How?
Extended the null check in both adapters to also handle the
['null']array form thathasManyrelationship fields produce:Fixes #16292