ci: use SLACK_CHANNEL env var for activity notifications#16323
Merged
Conversation
paulpopus
approved these changes
Apr 20, 2026
Contributor
|
🚀 This is included in version v3.84.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Updates the activity notifications workflow and action scripts to read the Slack channel from a
SLACK_CHANNELsecret rather than hardcoded constants. Also fixes a bug where step failures were silently swallowed.Key Changes
Remove
CHANNELSconstantssrc/constants.tsand its imports from both action modules. The channel is now read fromprocess.env.SLACK_CHANNEL, validated at startup with aTypeErrorif unset.Add
SLACK_CHANNELto workflow envactivity-notifications.ymlnow passesSLACK_CHANNEL: ${{ secrets.SLACK_CHANNEL }}. This makes the target channel configurable without code changes.Remove
continue-on-error: truefrom both stepscontinue-on-error: true, which caused script failures to be reported as passed at the job level. Removing it surfaces failures correctly.Design Decisions
SLACK_CHANNELaccepts either a channel name (e.g.#payload-dev) or a channel ID (e.g.C1234567890). Channel ID is recommended since it stays stable if the channel is renamed.The
DEBUGrouting logic (which previously switched betweenCHANNELS.DEVandCHANNELS.DEBUG) has been removed along with the constants. The channel is now set directly via the secret.