fix(richtext-lexical): drag/drop image into rich text fails when a field name matches the collection slug#16397
Merged
GermanJablo merged 3 commits intopayloadcms:mainfrom Apr 29, 2026
Conversation
- Updated `tsconfig.base.json` to reference the new configuration for `@payload-config`. - Introduced `LexicalSlugFieldNameCollision` collection to handle cases where a top-level rich text field name matches the collection slug. - Added a new `Collision` interface to manage collision data structure. - Updated various interfaces in `payload-types.ts` to use `string` for `id` fields instead of `number`. - Implemented drag-and-drop functionality for file uploads in `LexicalHelpers`. - Created end-to-end tests for the new collision handling feature in `e2e.spec.ts`. - Added necessary slugs and utility functions to support the new feature.
GermanJablo
force-pushed
the
cursor/6a987709
branch
from
8f407a6 to
91c2ad7
Compare
AlessioGr
approved these changes
Apr 27, 2026
GermanJablo
added a commit
that referenced
this pull request
Apr 29, 2026
…eld name matches the collection slug (#16409) ## Summary Backport of #16397 to 3.x. When a top-level rich text field has the same `name` as the collection's `slug`, dragging or pasting an image into the editor opens a blank bulk upload drawer. The lexical field and the document layout both mount a `BulkUploadProvider`; when the field path equals the collection slug they compute the same drawer slug and render two drawers for it, one with empty state (blank), which is what the user sees. The fix is a 1-line change: namespace the lexical field's nested `BulkUploadProvider` with a `lexical-` prefix so its drawer slug can never collide with the document-level provider. ```diff - <BulkUploadProvider drawerSlugPrefix={path}> + <BulkUploadProvider drawerSlugPrefix={`lexical-${path}`}> ``` The rest of the diff is a new e2e test. ## Test plan Added `test/lexical/collections/LexicalSlugFieldNameCollision/e2e.spec.ts`, which asserts that dropping a file into a rich text editor opens exactly one bulk upload drawer when the field name equals the collection slug. Verified that the test fails without the production change (`Expected: 1, Received: 2`) and passes with it. Co-authored-by: German Jablonski <GermanJablo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a top-level rich text field has the same
nameas the collection'sslug, dragging or pasting an image into the editor opens a blank bulk upload drawer. The lexical field and the document layout both mount aBulkUploadProvider; when the field path equals the collection slug they compute the same drawer slug and render two drawers for it, one with empty state (blank), which is what the user sees.The fix is a 1-line change: namespace the lexical field's nested
BulkUploadProviderwith alexical-prefix so its drawer slug can never collide with the document-level provider.The rest of the diff is a new e2e test.
Test plan
Added
test/lexical/collections/LexicalSlugFieldNameCollision/e2e.spec.ts, which asserts that dropping a file into a rich text editor opens exactly one bulk upload drawer when the field name equals the collection slug. Verified that the test fails without the production change (Expected: 1, Received: 2) and passes with it.