fix: guard against NaN when searching versioned collections by ID#16451
Open
aayushbaluni wants to merge 1 commit intopayloadcms:mainfrom
Open
fix: guard against NaN when searching versioned collections by ID#16451aayushbaluni wants to merge 1 commit intopayloadcms:mainfrom
aayushbaluni wants to merge 1 commit intopayloadcms:mainfrom
Conversation
When searching collections with drafts enabled, the search logic parses the search term as a numeric ID for parent_id comparison. Non-numeric search terms produced NaN, which caused 'invalid input syntax for type integer' errors on Postgres. Fixes payloadcms#15648
aayushbaluni
force-pushed
the
fix/15648-search-nan-draft-id
branch
from
239bc6b to
0c6f960
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When list search merges an
idcondition and drafts are enabled,appendVersionToQueryKeyrewritesidtoparent. For numeric collection IDs,sanitizeQueryValuecoerced the search string withNumber()without rejecting non-numeric input, producingNaNas a bound parameter againstparent_id(integer). Postgres then failed withinvalid input syntax for type integer: "NaN".This change returns
nullfromsanitizeQueryValuewhen the coerced relationship ID isNaN, soparseParamsskips adding that constraint (same pattern as polymorphic relationship handling). Other searchable fields in the same OR continue to work.Fixes #15648
Made with Cursor