fix: stop workflows retrying forever when no retries are configured#16465
Merged
Conversation
…16450) Jobs with a workflow that had no `retries` configured would retry forever with no backoff if the workflow handler threw an error. We hit this when a task slug was removed from config in a deploy after the job was queued - the inline single-task workflow would throw a `TypeError` calling the missing task. Why the bug existed: when a *task* throws, `handleTaskError` runs first and uses the task's own `retries` value to cap retries, so a workflow with no `retries` is fine - the task's retry limit is what stops the loop. But when the workflow *handler itself* throws, the error skips `handleTaskError` and goes straight to `handleWorkflowError`. The existing default there for "no workflow retries set" was "retry indefinitely, the task's limit will stop it" - except no task was ever involved, so nothing stopped the loop. `handleWorkflowError` now permanently fails the job when the workflow has no retries set. The task case is unchanged on purpose: a workflow without retries that calls a task with `retries: 3` still retries the task up to 3 times like before. There's also a smaller fix for jobs whose `workflowSlug` is no longer in config - those previously returned early without calling `updateJob`, leaving them stuck in `processing: true` indefinitely.
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
DanRibbens
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #16450