fix(richtext-lexical): cursor kicked out of nested richtext while typing in a block#16490
Merged
fix(richtext-lexical): cursor kicked out of nested richtext while typing in a block#16490
Conversation
…ing in a block (#16478) With autosave enabled, typing into a richtext field nested inside a Lexical block randomly kicks the cursor out of the nested editor and silently drops any characters typed after the jump. The block keeps its data in sync with the outer lexical editor by calling `editor.update(() => node.setFields(...))` whenever the inner block form's onChange fires. That update runs Lexical's `updateDOMSelection`, sees the active element sitting inside a nested contenteditable rather than the outer editor's own selection, and forcibly resets DOM selection back into the outer root. The fix passes `SKIP_DOM_SELECTION_TAG` to the data-sync `editor.update` calls in both block components so the reconciler leaves DOM selection alone during these syncs. ## Before https://github.com/user-attachments/assets/dbbacd93-2c1f-4f2b-9bfa-ecac300d3917 ## After https://github.com/user-attachments/assets/b74aae33-0559-44b0-bf51-49b9063bc7ca --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1214500030269826
PatrikKozak
approved these changes
May 5, 2026
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #16478