fix(plugin-cloud-storage): dedupe filename in clientUploads signed URL#16510
Merged
Conversation
#16495) When a user uploads via clientUploads and the collection already has a doc with that filename, the signed URL endpoint was signing against the original name, so the browser PUT overwrote the existing blob in storage. The new doc's row got deduplicated to `photo-1.jpg` by the normal server-side rename, but the blob in Azure/S3/GCS/R2 was at `photo.jpg` - so the new doc 404s on its image URL and the first doc silently ends up pointing at the doc. The signed-URL handler now runs `getSafeFileName` against the database before signing and threads the resolved name back through the response, where the browser-side handler picks it up via `updateFilename` so the form saves with the matching filename. ## Before https://github.com/user-attachments/assets/01f0a1ee-f525-4cd9-8b05-b3a20e6d0490 ## After https://github.com/user-attachments/assets/7d8b1869-c632-47f6-9222-eb80056a3dbd --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1214545490451773
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
DanRibbens
approved these changes
May 6, 2026
Member
|
🚀 This is included in version v3.85.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #16495