feat(ui): v4 app header reskin with sidebar toggle#16619
Merged
Conversation
Position both hidden and visible popup states off-screen initially to prevent brief appearance at (0,0) which caused viewport width changes during position calculation.
- Use Popup's renderButton prop for custom trigger - Add Language icon (24px globe) - Remove LocalizerLabel in favor of Button with icon - Single source of truth for button styles
- Remove LocalizerLabel spacer hack - Use flex gap for controls spacing - Clean up wrapper structure
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
PatrikKozak
previously requested changes
May 14, 2026
PatrikKozak
approved these changes
May 15, 2026
r1tsuu
added a commit
that referenced
this pull request
May 15, 2026
Resolved conflicts caused by two main-side changes: 1. SCSS-to-CSS conversion of Default template + ModularDashboard. Our branch had moved both modules from `packages/next` to `packages/ui`, so reapplied the same .scss -> .css swap inside the new home and copied over main's css contents. 2. AppHeader reskin (#16619) trimmed `CustomIcon` from `<AppHeader>`'s Props. Drop the now-unused prop from `DefaultTemplate` so ui builds pass. For the Nav / Default / ModularDashboard tsx conflicts kept our branch's delegation pattern - the next-side wrappers re-export the rebuilt UI versions from `@payloadcms/ui`, which already pick up main's behaviour through the dependency graph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reskins the app header for v4 UI and moves the sidebar toggle button into the header.
Changes
App Header
--app-header-heightwith padding-based sizing (--spacer-2-5)__bgelement and CSSCustomIcon,serverURL)Navigation
NavSidebarTogglefrom nav component and Default template--app-header-heightCSS variable (no longer needed)Dashboard Breadcrumb
buttonStyle="ghost"for consistent button stylingStepNav
Cleanup
packages/next/src/templates/Default/NavSidebarToggle/folder--app-header-heightfrom app.scss