fix(ui): improves pr #9576 by retaining search params in step nav#9604
Open
marwinhormiz wants to merge 3 commits intopayloadcms:mainfrom
Open
fix(ui): improves pr #9576 by retaining search params in step nav#9604marwinhormiz wants to merge 3 commits intopayloadcms:mainfrom
marwinhormiz wants to merge 3 commits intopayloadcms:mainfrom
Conversation
…ep nav PR payloadcms#9576 fixes the issue with not preserving the search params when going back to the list view after visiting a document, but it only works by going back in the browser and not through the breadcrumbs or 'step nav'. This solves it by adding a query field in the context type and making sure that the url and query is added in the List component directly.
jacobsfletch
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #9576 fixes the issue with the ui not retaining the search params when going back to a collection list view after visiting a document, but it only works when going back in the browser and not through the breadcrumbs or 'step nav'. This PR improves it by adding a new query field in the StepNavItem type and making sure that the search params are added to the query field in the List component, so it can be referenced in SetDocumentStepNav component to add it to the new step nav.