Skip to content

first version of changes to avoid accidental worker state update during worker recovery#408

Merged
rasamala83 merged 10 commits intopaypal:mainfrom
rasamala83:non_graceful_worker_recovery_issues
Jan 31, 2025
Merged

first version of changes to avoid accidental worker state update during worker recovery#408
rasamala83 merged 10 commits intopaypal:mainfrom
rasamala83:non_graceful_worker_recovery_issues

Conversation

@rasamala83
Copy link
Collaborator

No description provided.

@rasamala83 rasamala83 marked this pull request as draft December 16, 2024 11:39
Copy link
Collaborator

@shtiencode shtiencode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replying on limited defined states allowed during recover (at the duration of workerclient.isUnderRecover may be able to simplify the set state change. Please take a look.

@rasamala83 rasamala83 self-assigned this Jan 17, 2025
Copy link
Collaborator

@shtiencode shtiencode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good.

@rasamala83 rasamala83 marked this pull request as ready for review January 31, 2025 18:37
@rasamala83 rasamala83 merged commit 44bebff into paypal:main Jan 31, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants