Add energy metrics to load-watcher#73
Merged
lenhattan86 merged 2 commits intopaypal:masterfrom Nov 12, 2024
Merged
Conversation
lenhattan86
requested changes
Nov 5, 2024
| metricType = watcher.Memory | ||
| } else if metric == promDiskIOMetric { | ||
| metricType = watcher.Storage | ||
| } else if metric == promScaphHostPower { |
Collaborator
There was a problem hiding this comment.
I think we should use switch case for this.
Contributor
Author
There was a problem hiding this comment.
I agree. What about something like this:
switch metric {
case promCpuMetric: // CPU metrics
metricType = watcher.CPU
case promMemMetric: // Memory metrics
metricType = watcher.Memory
case promDiskIOMetric: // Storage metrics
metricType = watcher.Storage
case promScaphHostPower, promScaphHostJoules, // Energy-related metrics
promKeplerHostCoreJoules, promKeplerHostUncoreJoules,
promKeplerHostDRAMJoules, promKeplerHostPackageJoules,
promKeplerHostOtherJoules, promKeplerHostGPUJoules,
promKeplerHostPlatformJoules, promKeplerHostEnergyStat:
metricType = watcher.Energy
case promTransBandMetric, promTransBandDropMetric, // Bandwidth-related metrics
promRecBandMetric, promRecBandDropMetric:
metricType = watcher.Bandwidth
default:
metricType = watcher.Unknown
}
lenhattan86
approved these changes
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Addition of energy metrics in load-watcher.
Related issue
#72
Summary
Additional metrics: