Skip to content

Payment api url is fixed#79

Merged
chao-chang-paypay merged 2 commits intomasterfrom
fix/paymenturl
Nov 4, 2021
Merged

Payment api url is fixed#79
chao-chang-paypay merged 2 commits intomasterfrom
fix/paymenturl

Conversation

@navin-math
Copy link
Copy Markdown
Contributor

Description

Payment request is not getting executed as wrong payment api request url is set in the python SDK and fix is made to correct this payment api request url. After this fix, user can make payment without any issue.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you read and signed the automated Contributor's License Agreement?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@curtisfennerpaypay curtisfennerpaypay self-requested a review November 2, 2021 17:01
Copy link
Copy Markdown
Contributor

@curtisfennerpaypay curtisfennerpaypay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing test needs to be fixed still

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chao-chang-paypay chao-chang-paypay merged commit 63a7244 into master Nov 4, 2021
@chao-chang-paypay chao-chang-paypay deleted the fix/paymenturl branch November 4, 2021 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants