PRE-3182 feat: Create payment gateway#4
Merged
hdelaforce-payplug merged 1 commit intodevelopfrom Feb 16, 2026
Merged
Conversation
hdelaforce-payplug
force-pushed
the
PRE-3182-create-payment-gateway
branch
from
261018d to
f408ded
Compare
ilajili
reviewed
Feb 16, 2026
ilajili
reviewed
Feb 16, 2026
| { | ||
| // todo : Set validator to check this point | ||
| // Vérification des clés attendues dans $context | ||
| foreach ($this->expected_context as $expectedKey) { |
There was a problem hiding this comment.
is see that both kamel case and snake case are used here ( expextedKey and expected_context) i think it's better if we normalize casing
ilajili
reviewed
Feb 16, 2026
src/gateways/PaymentGateway.php
Outdated
| } | ||
| $payment_gateway = new $payment_gateway_path(); | ||
| } catch (\Exception $e) { | ||
| return null; |
There was a problem hiding this comment.
same comment as #3 silent exception is confusing
hdelaforce-payplug
force-pushed
the
PRE-3182-create-payment-gateway
branch
from
f408ded to
3e9d1d9
Compare
hdelaforce-payplug
force-pushed
the
PRE-3182-create-payment-gateway
branch
from
3e9d1d9 to
513747c
Compare
ilajili
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.