add PaywallService registration to ServiceCollectionExtensions#6
Merged
enespaywall merged 2 commits intodevfrom May 15, 2025
Merged
add PaywallService registration to ServiceCollectionExtensions#6enespaywall merged 2 commits intodevfrom
enespaywall merged 2 commits intodevfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds an overloaded AddPaywallService extension that accepts a PayWallOptions instance and handler factory delegates for more flexible client configuration.
- Introduced a new
AddPaywallService(this IServiceCollection, PayWallOptions, params Func<IServiceProvider, DelegatingHandler>[])overload - Registers four API clients and the
PayWallServiceusing the provided options and handlers
Comments suppressed due to low confidence (1)
src/PayWall.NetCore/ServiceCollectionExtensions.cs:58
- No unit tests cover this new overload. Add integration or unit tests to verify that all API clients and the
PayWallServiceare registered correctly when using thePayWallOptionsoverload.
public static void AddPaywallService(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new overloaded method
AddPaywallServicein theServiceCollectionExtensionsclass to provide additional flexibility when configuring paywall-related services.Key change:
src/PayWall.NetCore/ServiceCollectionExtensions.cs: Added an overloadedAddPaywallServicemethod that acceptsPayWallOptionsand an array ofDelegatingHandlerfactories. This method configures multiple API clients (PaymentApiClient,PaymentPrivateApiClient,CardWallApiClient, andMemberApiClient) and registers thePayWallServiceas a transient service.