Skip to content

use updated schema for update transaction expense data #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byjoh merged 1 commit into from
Mar 30, 2025
Merged

use updated schema for update transaction expense data #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions extend/resources/transactions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,20 +84,12 @@ async def update_transaction_expense_data(self, transaction_id: str, data: Dict)
data (Dict): A dictionary representing the expense data to update, should match
the schema:
{
"supplier": {
"name": "Some Supplier",
"id": "supplier-id"
},
"expenseCategories": [
"expenseDetails": [
{
"categoryCode": "COMPCODE",
"labelCode": "ABC123"
"categoryId": "ec_1234",
"labelId": "ecl_1234"
}
],
"customer": {
"name": "Some Customer",
"id": "customer-id"
}
}

Returns:
Expand Down
14 changes: 4 additions & 10 deletions tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,10 +389,8 @@ async def test_update_transaction_expense_data_success(extend, mocker, mock_tran
mock_response = {
"transaction": {
**mock_transaction,
"supplier": {"name": "Acme Inc", "id": "sup_123"},
"customer": {"name": "Client A", "id": "cust_456"},
"expenseCategories": [
{"categoryCode": "TRAVEL", "labelCode": "TAXI"}
"expenseDetails": [
{"categoryId": "ec_1234", "labelId": "ecl_1234"}
]
}
}
Expand All @@ -406,15 +404,11 @@ async def test_update_transaction_expense_data_success(extend, mocker, mock_tran
response = await extend.transactions.update_transaction_expense_data(
transaction_id=mock_transaction["id"],
data={
"supplier": {"name": "Acme Inc", "id": "sup_123"},
"customer": {"name": "Client A", "id": "cust_456"},
"expenseCategories": [{"categoryCode": "TRAVEL", "labelCode": "TAXI"}]
"expenseDetails": [{"categoryId": "ec_1234", "labelId": "ecl_1234"}]
}
)

assert response["transaction"]["supplier"]["name"] == "Acme Inc"
assert response["transaction"]["customer"]["id"] == "cust_456"
assert response["transaction"]["expenseCategories"][0]["categoryCode"] == "TRAVEL"
assert response["transaction"]["expenseDetails"][0]["categoryId"] == "ec_1234"


@pytest.mark.asyncio
Expand Down