Use EqualFold ti avoid memory reallocations#129
Merged
daveshanley merged 1 commit intopb33f:mainfrom Jun 17, 2023
Merged
Conversation
Author
|
First profile with ToLower Second with EqualFold |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 146 146
Lines 10091 10091
=======================================
Hits 10067 10067
Misses 24 24
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
daveshanley
approved these changes
Jun 17, 2023
Member
daveshanley
left a comment
daveshanley
left a comment
There was a problem hiding this comment.
Oh wow, this is great! Thank you!
Member
|
I will include this with the |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On very large specs
ToLowerbecomes a bottleneck since it reallocates a lot