fix windows no-console hang and add windows CI build#270
Merged
Conversation
Avoid querying the terminal for background color when stdin/stderr are not TTYs, which previously caused the CLI to hang on Windows when launched with no attached console. Fall back to env-based dark-background detection in that case. Add a Windows CI job and a subprocess regression test that runs the binary with CREATE_NO_WINDOW to guard against the hang. Switch both workflows to go-version-file with module caching and use `go mod download` instead of `go get`. Bump pb33f/doctor to v0.0.65, promote charmbracelet/x/term to a direct dependency, and bump @pb33f/cowboy-components to 0.15.1 with rebuilt bundles.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid querying the terminal for background color when stdin/stderr are not TTYs, which previously caused the CLI to hang on Windows when launched with no attached console. Fall back to env-based dark-background detection in that case.
Add a Windows CI job and a subprocess regression test that runs the binary with CREATE_NO_WINDOW to guard against the hang. Switch both workflows to go-version-file with module caching and use
go mod downloadinstead ofgo get.Bump pb33f/doctor to v0.0.65, promote charmbracelet/x/term to a direct dependency, and bump @pb33f/cowboy-components to 0.15.1 with rebuilt bundles.