[FEATURE] improve bash completion script

[ipariparipa]

# Bash completion script for QOwnNotes
_QOwnNotes() {
  COMPREPLY=()
  local current="${COMP_WORDS[COMP_CWORD]}"
  local prev="${COMP_WORDS[COMP_CWORD-1]}"
  _init_completion || return
  local commands="--h --help --portable --dump-settings --version --allow-multiple-instances --clear-settings --session --action --completion --decrypt-note --decrypt-note-password "
  if [[ "$prev" == "--decrypt-note" ]]; then
      compopt -o filenames
      _filedir
      return 0
  fi
  if [[ "$prev" == "--decrypt-note-password" ]]; then
      return 0
  fi
  if [[ "$prev" == "--session" ]]; then
      return 0
  fi
  if [[ "$prev" == "--action" ]]; then
      return 0
  fi
  if [[ "$prev" == "--completion" ]]; then
      COMPREPLY=( $(compgen -W "bash fish" -- "$current") )
      return 0
  fi

  COMPREPLY=( $(compgen -W "${commands}" -- ${current}) )
  return 0
}
complete -F _QOwnNotes QOwnNotes

[pbek]

The bash shell completion is created by:

QOwnNotes/src/utils/cli.cpp

Lines 65 to 84 in 6cfec80

	// Generates Bash shell completion script
	void Utils::Cli::generateBashCompletionScript(const QList<QCommandLineOption>& options,
	const QString& appName) {
	std::cout << "# Bash completion script for " << appName.toStdString() << std::endl;
	std::cout << "_" << appName.toStdString() << "() {" << std::endl;
	std::cout << " COMPREPLY=()" << std::endl;
	std::cout << " local current=\"${COMP_WORDS[COMP_CWORD]}\"" << std::endl;
	std::cout << " local commands=\"";
	for (const QCommandLineOption& option : options) {
	for (const QString& name : option.names()) {
	std::cout << "--" << name.toStdString() << " ";
	}
	}
	std::cout << "\"" << std::endl;
	std::cout << " COMPREPLY=( $(compgen -W \"${commands}\" -- ${current}) )" << std::endl;
	std::cout << " return 0" << std::endl;
	std::cout << "}" << std::endl;
	std::cout << "complete -F _" << appName.toStdString() << " " << appName.toStdString()
	<< std::endl;
	}

It can be generated with QOwnNotes --completion bash. Changes to that would need to go directly to above method.

[pbek]

I'll come up with something.

[pbek]

26.6.2

• Improved bash shell completion by completing proper short and long command line
  options, shell names for --completion, and filenames for --decrypt-note
  (for #3633)

There now is a new release, could you please test it and report if it works for you?

[ipariparipa]

good. 👍