Skip to content

Conversation

@Waqar144
Copy link
Contributor

No description provided.

@Waqar144 Waqar144 force-pushed the work/fakevim-update branch 3 times, most recently from 38f3ded to 9546537 Compare June 25, 2021 18:10
@pbek pbek added the WIP PR that is still being worked on label Jun 25, 2021
@Waqar144 Waqar144 force-pushed the work/fakevim-update branch from 9546537 to 3cacb76 Compare June 25, 2021 18:33
@pbek
Copy link
Owner

pbek commented Jun 25, 2021

You are my hero! 😁

@pbek
Copy link
Owner

pbek commented Jun 26, 2021

Only one pre-processor if clause left to fix:

libraries/fakevim/fakevim/fakevimhandler.cpp:2836:56: error: no member named 'horizontalAdvance' in 'QFontMetrics'
    const int charWidth = QFontMetrics(EDITOR(font())).horizontalAdvance(' ');
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^

😁

@Waqar144 Waqar144 force-pushed the work/fakevim-update branch from 3cacb76 to 57b10d0 Compare June 26, 2021 07:27
@pbek
Copy link
Owner

pbek commented Jun 27, 2021

Is the PR ready now, @Waqar144?

@pbek
Copy link
Owner

pbek commented Jun 27, 2021

Btw. does it also work with cmake?

@pbek
Copy link
Owner

pbek commented Jun 27, 2021

Btw. does it also work with cmake?

it works if I remove this from cmake/pkg-config.cmake:

configure_file(
    "${CMAKE_CURRENT_SOURCE_DIR}/pkg-config.pc.in"
    "${CMAKE_CURRENT_BINARY_DIR}/${bin}.pc"
    )

@pbek pbek merged commit 92862ca into pbek:develop Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP PR that is still being worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants