Skip to content

glue/misc: Implement u8s2str and str2u8s #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
disjukr merged 1 commit into from
May 5, 2022
Merged

glue/misc: Implement u8s2str and str2u8s #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/glue/misc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
export function u8s2str(u8s: Uint8Array): string {
return ""; // TODO
return Array.from(u8s).map((u8) => String.fromCharCode(u8)).join("");
}

export function str2u8s(str: string): Uint8Array {
return new Uint8Array(); // TODO
return new Uint8Array(
Array.from(str).map((char) => {
const code = char.codePointAt(0);
if (code == null) throw new Error("Unexpected character");
Copy link
Member Author

@hyp3rflow hyp3rflow May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we throw an error in here?

Copy link
Member

@disjukr disjukr May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

umm maybe okay

return code;
}),
);
}