-
Notifications
You must be signed in to change notification settings - Fork 0
require manual unpause when app is refocused #4
Conversation
|
@hunter-pbs this behavior makes sense to me, but I didn't see this functionality listed on that ticket - is this something that Kelly is aware of, that we're changing what happens when you re-focus the play page? |
Sorry, I referenced the wrong Pause ticket in the changelog. Has been updated. This behavior is detailed here: |
fuentism
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but let's let @renzoolguin weigh in on this one too since this will be our first commit to the container code. Woo!
renzoolguin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I was a little confused at first because it looked we were PR'ing into the original repo and not the fork due to the similar repo names. Maybe we could at least update the README to reflect that this is for the redesign site?
@renzoolguin @fuentism |
Let's start tracking the Redesign work as 3.0.0+ Note in that version that is the start of redesign work. That way any updates in 2.x.y can be merged in if any changes in the original repo need to be pulled in. |
Instead of toggling pause state on application focus, just set pause to true when focus is lost, requiring a manual unpause via pause buttons.