fix: Always perform at least one step of milling.#678
Merged
eyal0 merged 2 commits intopcb2gcode:masterfrom Aug 21, 2023
Merged
fix: Always perform at least one step of milling.#678eyal0 merged 2 commits intopcb2gcode:masterfrom
eyal0 merged 2 commits intopcb2gcode:masterfrom
Conversation
Laser cutters might need to set zwork to 0 or stepsize to 0, which caused the code to compute that no milling/cutting needs to be done at all! It seems unlikely that someone would not want to do any work at all so we'll make sure that there is always at least one pass.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #677